From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MyMum-0006KY-Bf for qemu-devel@nongnu.org; Thu, 15 Oct 2009 05:46:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MyMuk-0006IY-Hw for qemu-devel@nongnu.org; Thu, 15 Oct 2009 05:46:31 -0400 Received: from [199.232.76.173] (port=52516 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyMuk-0006IF-4k for qemu-devel@nongnu.org; Thu, 15 Oct 2009 05:46:30 -0400 Received: from hall.aurel32.net ([88.191.82.174]:40931) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MyMuj-0005NK-PN for qemu-devel@nongnu.org; Thu, 15 Oct 2009 05:46:29 -0400 Date: Thu, 15 Oct 2009 11:46:22 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present Message-ID: <20091015094622.GA18638@volta.aurel32.net> References: <473191350910132348y7e9b9738wdf591b0589a9e86a@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <473191350910132348y7e9b9738wdf591b0589a9e86a@mail.gmail.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roy Tam Cc: qemu-devel@nongnu.org On Wed, Oct 14, 2009 at 02:48:21PM +0800, Roy Tam wrote: > As i8259 in mips_jazz.c is not connect to isa bus correctly, this > patch fix that. It looks fine. Could you please resend the patch with a Signed-off-by: > diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c > index 3ff367d..281713c 100644 > --- a/hw/mips_jazz.c > +++ b/hw/mips_jazz.c > @@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size, > > /* ISA devices */ > i8259 = i8259_init(env->irq[4]); > + isa_bus_new(NULL); > + isa_bus_irqs(i8259); > DMA_init(0); > pit = pit_init(0x40, i8259[0]); > pcspk_init(pit); > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net