Re: [Qemu-devel] [PATCH 01/10] Introduce qmisc module

[Luiz Capitulino <lcapitulino@redhat.com>]

On Thu, 15 Oct 2009 17:39:36 +0100
"Daniel P. Berrange" <berrange@redhat.com> wrote:

> On Thu, Oct 15, 2009 at 12:26:22PM -0300, Luiz Capitulino wrote:
> > On Thu, 15 Oct 2009 09:02:48 -0500
> > Anthony Liguori <anthony@codemonkey.ws> wrote:
> > 
> > > 
> > > If we're introducing third-party code under a new license, we need to 
> > > update the top-level LICENSE file.  I took a brief look and it wasn't 
> > > immediately clear that this license is GPL compatible.  According to the 
> > > FSF, certain versions of this license are incompatible and some are 
> > > compatible.  I think it would have been better to just write something 
> > > from scratch...
> > 
> >  According to the Python's LICENSE file it's compatible since 2001
> > (2.0.1 release).
> > 
> > > > +            case '[':
> > > > +                return do_mklist(fmt, args, ']', count_format(*fmt, ']'));
> > > >   
> > > 
> > > Because this is bizarre.  It looks ahead to count the number of 
> > > arguments which is a very strange way to parse something like this.
> > > 
> > > Why not a simple recursive decent parser?
> > 
> >  I could try it, but I think this is going to take some time as
> > I would have to read more about it.
> > 
> >  I thought the Python's implementation was a good idea as we're short
> > in time and it was easy to adapt and is widely used in production.
> 
> There are at least 6  standalone, pure C [1] json parsers available 
> already, some of which let you do json formatting too. So writing a
> new parser, or untangling one from python seems like more trouble than
> its worth to me. Likewise for generating formatted JSON output.

 Not the right context but I was going to post about this soon, so
I think this is a good opportunity to talk about it.

 I didn't look at all available parsers from json.org, but this one:

http://fara.cs.uni-potsdam.de/~jsg/json_parser/

 Seems interesting.

 Anthony, are you ok in using external implementations like that
if they meet our requirements?