From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MzdP7-0003Bx-Mt for qemu-devel@nongnu.org; Sun, 18 Oct 2009 17:35:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MzdP3-00037Y-2a for qemu-devel@nongnu.org; Sun, 18 Oct 2009 17:35:05 -0400 Received: from [199.232.76.173] (port=38796 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MzdP3-00037Q-0A for qemu-devel@nongnu.org; Sun, 18 Oct 2009 17:35:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11179) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MzdP2-0001Et-Hx for qemu-devel@nongnu.org; Sun, 18 Oct 2009 17:35:00 -0400 Date: Sun, 18 Oct 2009 19:34:52 -0200 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH 0/11] json parser (v2) Message-ID: <20091018193452.75794e9e@doriath> In-Reply-To: <1255786571-3528-1-git-send-email-aliguori@us.ibm.com> References: <1255786571-3528-1-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On Sat, 17 Oct 2009 08:36:00 -0500 Anthony Liguori wrote: > I fat-fingered the git send-email command the first time so here's the second > iteration. Got it now.. > This series introduces a json parsing framework. The parser is a recursive > decent parser and implements the full json spec except for the null keyword. We > need to decide how we want to model null in order to support this. > > In addition, we implement an extension to allow single quote strings. This > is very useful for defining dictionaries in C. > > The parser has a full test suite and introduces a boolean and float type. Very nice, this is obviously way beyond the simple approach I was following, I have some minor comments and will reply some patches. Will also run some tests later today, but I don't think I'll find any issue (given that you have written unit-tests!). What's you merge plan for your own patches? :)