From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: mtosatti@redhat.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] qemu-0.11.50 build breaks at monitor.c
Date: Mon, 19 Oct 2009 12:41:45 +0530 [thread overview]
Message-ID: <20091019071145.GA5935@linux.vnet.ibm.com> (raw)
Hi Marcelo,
qemu-0.11.50 build breaks with
CC x86_64-softmmu/monitor.o
cc1: warnings being treated as errors
/other/srcs/qemu-kvm/monitor.c: In function 'print_cpu_iter':
/other/srcs/qemu-kvm/monitor.c:450: error: format '%ld' expects type 'long int', but argument 3 has type 'int64_t'
make[3]: *** [monitor.o] Error 1
Changes to print_cpu_iter was introduced by
commit 00ee594280d46290629ccd5fcd1b5c1a21605e4c
Author: Marcelo Tosatti <mtosatti@redhat.com>
Date: Wed Oct 14 19:21:10 2009 -0300
Add missing thread_id field in "info cpus"
typecasting it int long, helps
monitor.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/monitor.c b/monitor.c
index b4c4878..5416fdb 100644
--- a/monitor.c
+++ b/monitor.c
@@ -447,7 +447,7 @@ static void print_cpu_iter(QObject *obj, void *opaque)
if (strcmp(qdict_get_str(cpu, "halted"), "yes") == 0)
monitor_printf(mon, " (halted)");
- monitor_printf(mon, " thread_id=%ld", qdict_get_int(cpu, "thread_id"));
+ monitor_printf(mon, " thread_id=%ld", (int long)qdict_get_int(cpu, "thread_id"));
monitor_printf(mon, "\n");
}
Kamalesh
next reply other threads:[~2009-10-19 7:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 7:11 Kamalesh Babulal [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-10-19 7:50 [Qemu-devel] qemu-0.11.50 build breaks at monitor.c Laurent Vivier
2009-10-19 8:21 ` Kamalesh Babulal
2009-10-19 18:30 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019071145.GA5935@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).