From: Marcelo Tosatti <mtosatti@redhat.com>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: Laurent Vivier <Laurent@vivier.eu>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu-0.11.50 build breaks at monitor.c
Date: Mon, 19 Oct 2009 16:30:37 -0200 [thread overview]
Message-ID: <20091019183037.GA14383@amt.cnet> (raw)
In-Reply-To: <20091019082102.GB5935@linux.vnet.ibm.com>
On Mon, Oct 19, 2009 at 01:51:02PM +0530, Kamalesh Babulal wrote:
> > >+ monitor_printf(mon, " thread_id=%ld", (int long)qdict_get_int(cpu,
> > >"thread_id"));
> >
> > You should use %PRId64 instead of %ld.
>
> Hi Laurent,
>
> Thanks for the review.
>
> Resending the patch with changes recommended by Laurent.
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Applied, thanks.
next prev parent reply other threads:[~2009-10-19 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 7:50 [Qemu-devel] qemu-0.11.50 build breaks at monitor.c Laurent Vivier
2009-10-19 8:21 ` Kamalesh Babulal
2009-10-19 18:30 ` Marcelo Tosatti [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-10-19 7:11 Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019183037.GA14383@amt.cnet \
--to=mtosatti@redhat.com \
--cc=Laurent@vivier.eu \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).