From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N0BNJ-0004ld-IB for qemu-devel@nongnu.org; Tue, 20 Oct 2009 05:51:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N0BNF-0004kT-Ej for qemu-devel@nongnu.org; Tue, 20 Oct 2009 05:51:29 -0400 Received: from [199.232.76.173] (port=51792 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0BNF-0004kL-5q for qemu-devel@nongnu.org; Tue, 20 Oct 2009 05:51:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4095) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N0BNE-0002TM-MC for qemu-devel@nongnu.org; Tue, 20 Oct 2009 05:51:24 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9K9pNIi010038 for ; Tue, 20 Oct 2009 05:51:24 -0400 Date: Tue, 20 Oct 2009 15:20:44 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH v9 0/3] virtio-console: Add support for multiple ports for generic guest-host communication Message-ID: <20091020095044.GB4405@amit-x200.redhat.com> References: <1256022825-16180-1-git-send-email-amit.shah@redhat.com> <4ADD7B48.2030704@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ADD7B48.2030704@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On (Tue) Oct 20 2009 [10:56:40], Gerd Hoffmann wrote: > Hi, > >> This patch series fixes a few problems since the last send, mainly in >> the save/restore code and a few bugs shown by the automated test suite >> (located in a separate git repo, link below). > > A bit hard to review in this form, especially the virtio-console.c > changes, because you put everything upside down in that file. Hard to > do better though given the massive code reorganization ... Top-down is the usual way of writing code, isn't it (avoids fwd declarations too). Also, I've arranged the code according to some grouping: functions useful to outside users first, then functions using some outside facilities, and then intialisation functions. > So I applied the bits and looked at the resulting tree instead. Looks > good overall, just a few minor nits, check the replies to the individual > patches. I think we are ready to go as soon as the linux kernel side is > on the way to mainline. Yeah; waiting for Rusty's comments. Amit