From: "Richard W.M. Jones" <rjones@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports
Date: Tue, 20 Oct 2009 12:08:06 +0100 [thread overview]
Message-ID: <20091020110806.GA12094@amd.home.annexia.org> (raw)
In-Reply-To: <1256022825-16180-3-git-send-email-amit.shah@redhat.com>
On Tue, Oct 20, 2009 at 12:43:44PM +0530, Amit Shah wrote:
> DEF("virtioconsole", HAS_ARG, QEMU_OPTION_virtiocon, \
> "-virtioconsole c\n" \
> - " set virtio console\n")
> + " define virtio console\n")
It would be much better to add a detectable string here so we
(libguestfs) can tell if multiport is supported. Something like:
" set virtio console (multiport)\n"
> STEXI
> @item -virtioconsole @var{c}
> Set virtio console.
> +
> +This option is maintained for backward compatibility.
> +
> +Please use @code{-device virtioconsole} for the new way of invocation
I think you mean -device virtconsole here.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
next prev parent reply other threads:[~2009-10-20 11:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 7:13 [Qemu-devel] [PATCH v9 0/3] virtio-console: Add support for multiple ports for generic guest-host communication Amit Shah
2009-10-20 7:13 ` [Qemu-devel] [PATCH v9 1/3] qdev: add string property Amit Shah
2009-10-20 7:13 ` [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports Amit Shah
2009-10-20 7:13 ` [Qemu-devel] [PATCH v9 3/3] virtio-console: Add a new virtserialport device for generic serial port support Amit Shah
2009-10-20 8:51 ` Gerd Hoffmann
2009-10-20 9:48 ` Amit Shah
2009-10-20 14:02 ` Gerd Hoffmann
2009-10-21 3:44 ` Amit Shah
2009-10-20 8:49 ` [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports Gerd Hoffmann
2009-10-20 11:08 ` Richard W.M. Jones [this message]
2009-10-20 12:01 ` Amit Shah
2009-10-20 12:05 ` Richard W.M. Jones
2009-10-20 12:16 ` Amit Shah
2009-10-20 8:56 ` [Qemu-devel] [PATCH v9 0/3] virtio-console: Add support for multiple ports for generic guest-host communication Gerd Hoffmann
2009-10-20 9:50 ` Amit Shah
2009-10-20 11:54 ` Dor Laor
2009-10-20 12:03 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091020110806.GA12094@amd.home.annexia.org \
--to=rjones@redhat.com \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).