From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N0CZm-0006J5-2u
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 07:08:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N0CZh-0006E6-Nz
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 07:08:25 -0400
Received: from [199.232.76.173] (port=57536 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N0CZh-0006E3-GD
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 07:08:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42004)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rjones@redhat.com>) id 1N0CZg-00075J-Vk
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 07:08:21 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9KB8J2i014848
	for <qemu-devel@nongnu.org>; Tue, 20 Oct 2009 07:08:20 -0400
Date: Tue, 20 Oct 2009 12:08:06 +0100
From: "Richard W.M. Jones" <rjones@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a
	virtio-serial bus, support for multiple ports
Message-ID: <20091020110806.GA12094@amd.home.annexia.org>
References: <1256022825-16180-1-git-send-email-amit.shah@redhat.com>
	<1256022825-16180-2-git-send-email-amit.shah@redhat.com>
	<1256022825-16180-3-git-send-email-amit.shah@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1256022825-16180-3-git-send-email-amit.shah@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, Oct 20, 2009 at 12:43:44PM +0530, Amit Shah wrote:
>  DEF("virtioconsole", HAS_ARG, QEMU_OPTION_virtiocon, \
>      "-virtioconsole c\n" \
> -    "                set virtio console\n")
> +    "                define virtio console\n")

It would be much better to add a detectable string here so we
(libguestfs) can tell if multiport is supported.  Something like:

       "                set virtio console (multiport)\n"

>  STEXI
>  @item -virtioconsole @var{c}
>  Set virtio console.
> +
> +This option is maintained for backward compatibility.
> +
> +Please use @code{-device virtioconsole} for the new way of invocation

I think you mean -device virtconsole here.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw