From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N0g1j-0000oI-7e
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 14:35:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N0g1e-0000mY-KM
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 14:35:14 -0400
Received: from [199.232.76.173] (port=51786 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N0g1c-0000mD-RT
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 14:35:09 -0400
Received: from mail2.shareable.org ([80.68.89.115]:38049)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jamie@shareable.org>) id 1N0g1c-0000hG-Eg
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 14:35:08 -0400
Date: Wed, 21 Oct 2009 19:35:03 +0100
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop
	VM
Message-ID: <20091021183503.GA27677@shareable.org>
References: <f284c33d0910180924h13762eebl4f029c9606988dec@mail.gmail.com>
	<4ADCE635.4060604@codemonkey.ws> <4ADD9388.8040206@redhat.com>
	<20091020170800.GG32538@redhat.com> <4ADEB7EF.3060800@redhat.com>
	<5d6222a80910210652q3b005ca6ub950a2014bfbaa41@mail.gmail.com>
	<f284c33d0910210904x7bfcba40r7dcf4ca4da66dc0c@mail.gmail.com>
	<5d6222a80910210924j62505b7dtf298754ce65f1c99@mail.gmail.com>
	<f284c33d0910210944k5223210eu83a073700975030f@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f284c33d0910210944k5223210eu83a073700975030f@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mulyadi Santosa <mulyadi.santosa@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Glauber Costa <glommer@gmail.com>, qemu-devel@nongnu.org

Mulyadi Santosa wrote:
> On Wed, Oct 21, 2009 at 11:24 PM, Glauber Costa <glommer@gmail.com> wrote:
> > You can provide a monitor command to do that
> >
> > something in the lines of:
> > - add_macro <key> <command_list>
> > - remove_macro <key>
> > - list_macros
> 
> Please CMIIW, "command_list" here refers to at least one of monitor
> commands, right? meaning, i.e one could do:
> add_macro ctrl_alt_shift_s "stop"
> 
> or extend that so it does:
> add_macro ctrl_alt_shift_s "stop print $pc"
> 
> so, it stops the VM followed by printing program counter.

If the monitor accepted ";" as a command separator, to put multiple
commands on a single line, <command_list> could just be a quoted
string which is processed as a line.

If we're going to have keyboard macros, it would be nice and probably
very easy to have monitor macros too - monitor commands which expand
to a line in the same way.

The number of times I've typed things like send_key control-alt-del
and would have appreciated a "cad" macro...

Syntax idea comes to mind is:

    - Add ";" as command separator.

    - add_macro <name> <command-string>
    - remove_macro <name>
    - list_macros

    - add_key key <key> <command-string>
    - remove_key <key> <command-string>
    - list_keys

(If I were starting from nothing it'd be macro_add, macro_remove
etc. or maybe "macro add", but the above seems more consistent with
the existing monitor)

-- Jamie