From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N1OD7-00056k-6Y
	for qemu-devel@nongnu.org; Fri, 23 Oct 2009 13:45:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N1OCx-00050Z-R1
	for qemu-devel@nongnu.org; Fri, 23 Oct 2009 13:45:52 -0400
Received: from [199.232.76.173] (port=47128 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N1OCx-00050P-KZ
	for qemu-devel@nongnu.org; Fri, 23 Oct 2009 13:45:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37472)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1N1OCx-0005R5-70
	for qemu-devel@nongnu.org; Fri, 23 Oct 2009 13:45:47 -0400
Date: Fri, 23 Oct 2009 15:45:38 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 04/11] Add json->qobject parser
Message-ID: <20091023154538.6d5282e2@doriath>
In-Reply-To: <1255786571-3528-5-git-send-email-aliguori@us.ibm.com>
References: <1255786571-3528-1-git-send-email-aliguori@us.ibm.com>
	<1255786571-3528-5-git-send-email-aliguori@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org

On Sat, 17 Oct 2009 08:36:04 -0500
Anthony Liguori <aliguori@us.ibm.com> wrote:

> +QObject *qobject_from_json(const char *string, size_t *length);
> +QObject *qobject_from_jsonf(const char *string, size_t *length, ...)
> +    __attribute__((__format__ (__printf__, 1, 3)));

 We need a wrapper for command handlers usage, they won't use 'length' and
I think we can abort() on error if the only possibility of failing is a
wrong syntax.