Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened

[Amit Shah <amit.shah@redhat.com>]

On (Sat) Oct 24 2009 [12:36:54], Jan Kiszka wrote:
> Amit Shah wrote:
> > The OPENED event gets sent also when qemu resets its state initially.
> > The consumers of the event aren't interested in receiving this event
> > on reset.
> 
> The monitor was. Now its initial prompt on activation is broken.

The patch in Anthony's queue, titled

'console: call qemu_chr_reset() in text_console_init'

fixed that.

However, with the qcow2 synchronous patch, the monitor prompt doesn't
come up again -- which shows there is a problem with the way the bhs
work and also the initial resets.

I think the initial resets are a hack to work around something from my
reading of it; do you have a better idea of why it's there and how it's
all supposed to work?

> Does this patch fix/improve something for a different user? If not,
> please let us revert it.

There's another question too: is a separate 'reset' event needed in
addition to an 'opened' event?

I have a few apps (that are coming as part of the virtio-console work)
that need just an 'opened' event and are not interested in the 'reset'
event.

		Amit