From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N347O-0003Dh-7L for qemu-devel@nongnu.org; Wed, 28 Oct 2009 04:42:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N347J-0003BH-LM for qemu-devel@nongnu.org; Wed, 28 Oct 2009 04:42:57 -0400 Received: from [199.232.76.173] (port=43904 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N347J-0003BB-Cb for qemu-devel@nongnu.org; Wed, 28 Oct 2009 04:42:53 -0400 Received: from verein.lst.de ([213.95.11.210]:45412) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1N347I-0001vF-RH for qemu-devel@nongnu.org; Wed, 28 Oct 2009 04:42:53 -0400 Date: Wed, 28 Oct 2009 09:42:47 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 3/4] scsi-disk: Factor out SCSI command emulation Message-ID: <20091028084247.GC17601@lst.de> References: <20091027152859.C6CF739742@ochil.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091027152859.C6CF739742@ochil.suse.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org On Tue, Oct 27, 2009 at 04:28:59PM +0100, Hannes Reinecke wrote: > > Other drives might want to use SCSI command emulation without > going through the SCSI disk abstraction, as this imposes too > many limits on the emulation. Might be a good idea to move something like this first into the series and share the CDB decoder between scsi and ide (atapi) as a start. A little bit of refactoring of the CDB decoder, e.g. into one function per opcode (-family) won't hurt either.