From: Stuart Brady <sdbrady@ntlworld.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 3/25] i386: add private features for a20mask
Date: Wed, 28 Oct 2009 20:26:10 +0000 [thread overview]
Message-ID: <20091028202610.GB8945@miranda.arrow> (raw)
In-Reply-To: <200910281632.AA00140@YOUR-BD18D6DD63.m1.interq.or.jp>
On Thu, Oct 29, 2009 at 01:32:51AM +0900, TAKEDA, toshiya wrote:
> This patch is to add private_features to i386.
> It is like cpuid_ext*_features, but is used for any features not defined in CPUID.
>
> And "a20mask" feature is defined in private_features.
> It is for a20 adrdress mask of PC-98 family.
I'd suggest giving it a name like "pc98_a20mask" to make it clear that it's a
PC-98 specific feature.
TBH, I wonder whether this really belongs as a CPU feature, as it's not
really something I would have thought should be exposed to the user...
although perhaps the same could be said about CPUID bits generally...
Presumably PC-98 provides the same A20 mask behaviour even when using a
486 or better (which IIUC have built-in A20 gate logic)?
BTW, your patches need a 'signed-off-by' line, which is your statement
that they follow the rules in the 'developer's certificate of origin':
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches
Cheers,
--
Stuart Brady
prev parent reply other threads:[~2009-10-28 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 16:32 [Qemu-devel] [PATCH v3 3/25] i386: add private features for a20mask TAKEDA, toshiya
2009-10-28 20:26 ` Stuart Brady [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091028202610.GB8945@miranda.arrow \
--to=sdbrady@ntlworld.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).