From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N3ZcQ-0000xi-Nw
	for qemu-devel@nongnu.org; Thu, 29 Oct 2009 14:21:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N3ZcL-0000wK-Tr
	for qemu-devel@nongnu.org; Thu, 29 Oct 2009 14:21:06 -0400
Received: from [199.232.76.173] (port=49894 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N3ZcL-0000wH-Pl
	for qemu-devel@nongnu.org; Thu, 29 Oct 2009 14:21:01 -0400
Received: from mtaout03-winn.ispmail.ntl.com ([81.103.221.49]:15578)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sdbrady@ntlworld.com>) id 1N3ZcL-0004Se-BD
	for qemu-devel@nongnu.org; Thu, 29 Oct 2009 14:21:01 -0400
Received: from aamtaout04-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout03-winn.ispmail.ntl.com
	(InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id
	<20091029182056.KRQW17277.mtaout03-winn.ispmail.ntl.com@aamtaout04-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Thu, 29 Oct 2009 18:20:56 +0000
Received: from miranda.arrow ([213.107.24.213])
	by aamtaout04-winn.ispmail.ntl.com
	(InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id
	<20091029182056.PNCF22934.aamtaout04-winn.ispmail.ntl.com@miranda.arrow>
	for <qemu-devel@nongnu.org>; Thu, 29 Oct 2009 18:20:56 +0000
Received: from sdb by miranda.arrow with local (Exim 4.63)
	(envelope-from <sdbrady@ntlworld.com>) id 1N3ZdZ-0002mX-Mb
	for qemu-devel@nongnu.org; Thu, 29 Oct 2009 18:22:17 +0000
Date: Thu, 29 Oct 2009 18:22:17 +0000
From: Stuart Brady <sdbrady@ntlworld.com>
Subject: Re: [Qemu-devel] [PATCH] target-arm: tcg temp variable usage cleanup
Message-ID: <20091029182217.GA10660@miranda.arrow>
References: <1256824875-46345-1-git-send-email-juha.riihimaki@nokia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1256824875-46345-1-git-send-email-juha.riihimaki@nokia.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Thu, Oct 29, 2009 at 04:01:15PM +0200, juha.riihimaki@nokia.com wrote:
>  
> -static inline TCGv gen_ld8s(TCGv addr, int index)
> +static inline void gen_ld8s(TCGv ret, TCGv addr, int index)
>  {
> -    TCGv tmp = new_tmp();
> -    tcg_gen_qemu_ld8s(tmp, addr, index);
> -    return tmp;
> +    tcg_gen_qemu_ld8s(ret, addr, index);
>  }
[...]
>  static inline void gen_st8(TCGv val, TCGv addr, int index)
>  {
>      tcg_gen_qemu_st8(val, addr, index);
> -    dead_tmp(val);
>  }
>  static inline void gen_st16(TCGv val, TCGv addr, int index)
>  {
>      tcg_gen_qemu_st16(val, addr, index);
> -    dead_tmp(val);
>  }
[...]

Why not remove these functions entirely, replacing them with calls to
tcg_gen_qemu_ld/st()?

I presume there's a reason, given this:

> @@ -1001,25 +955,24 @@ VFP_GEN_FIX(ulto)
>  static inline void gen_vfp_ld(DisasContext *s, int dp, TCGv addr)
>  {
>      if (dp)
> -        tcg_gen_qemu_ld64(cpu_F0d, addr, IS_USER(s));
> +        gen_ld64(cpu_F0d, addr, IS_USER(s));
>      else
> -        tcg_gen_qemu_ld32u(cpu_F0s, addr, IS_USER(s));
> +        gen_ld32(cpu_F0s, addr, IS_USER(s));
>  }

Cheers,
-- 
Stuart Brady