From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3v4b-0002AC-28 for qemu-devel@nongnu.org; Fri, 30 Oct 2009 13:15:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3v4W-00022s-5c for qemu-devel@nongnu.org; Fri, 30 Oct 2009 13:15:36 -0400 Received: from [199.232.76.173] (port=33822 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3v4V-00022a-Vq for qemu-devel@nongnu.org; Fri, 30 Oct 2009 13:15:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59764) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N3v4V-00054f-I3 for qemu-devel@nongnu.org; Fri, 30 Oct 2009 13:15:31 -0400 Date: Fri, 30 Oct 2009 17:15:14 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] Re: [RFC 0/7] QError v1 Message-ID: <20091030171514.GI21617@redhat.com> References: <1256841750-15228-1-git-send-email-lcapitulino@redhat.com> <4AEA133A.8010906@redhat.com> <20091030102809.1c520282@doriath> <4AEAE261.5030908@redhat.com> <4AEAE56E.8040309@us.ibm.com> <20091030162849.GH3579@shareable.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091030162849.GH3579@shareable.org> Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jamie Lokier Cc: Anthony Liguori , qemu-devel@nongnu.org, Luiz Capitulino , Gerd Hoffmann , Paolo Bonzini , hollisb@linux.vnet.ibm.com On Fri, Oct 30, 2009 at 04:28:49PM +0000, Jamie Lokier wrote: > Anthony Liguori wrote: > > Okay, let's get more clever then and do: > > > > #define QERR_DEV_NFOUND "{ 'code': 404, 'name': %s}" > > By the way, since you've already invented a non-standard JSON > extension, which is the single quotes, why not go a step further and > permit the quotes to be omitted for simple tokens? If we're going to use JSON we should be 100% compliant with the JSON spec, not extend it. By adding custom QEMU extensions, we loose the ability for programming language to trivially talk to QEMU using a standard JSON parser, and instead everyone has to write custom client side code yet again. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|