[Qemu-devel] Re: [PATCH] char: tcp: increase size of buffer that holds data to be sent out

[Amit Shah <amit.shah@redhat.com>]

On (Mon) Nov 02 2009 [21:59:58], Amit Shah wrote:
> 1k is too less; at least send out 4k of data from a chardev.

This one only touches unix/tcp sockets; the others use a 1k buffer as
well; I'll send a new patch that converts all the users to a consistent
buffer size.

> 
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
>  qemu-char.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/qemu-char.c b/qemu-char.c
> index 0fd402c..34c0a63 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1996,7 +1996,7 @@ static void tcp_chr_read(void *opaque)
>  {
>      CharDriverState *chr = opaque;
>      TCPCharDriver *s = chr->opaque;
> -    uint8_t buf[1024];
> +    uint8_t buf[4096];
>      int len, size;
>  
>      if (!s->connected || s->max_size <= 0)
> -- 
> 1.6.2.5
> 

		Amit