From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N504Z-0002ut-3M
	for qemu-devel@nongnu.org; Mon, 02 Nov 2009 11:48:03 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N504U-0002pj-B2
	for qemu-devel@nongnu.org; Mon, 02 Nov 2009 11:48:02 -0500
Received: from [199.232.76.173] (port=39877 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N504U-0002pd-4s
	for qemu-devel@nongnu.org; Mon, 02 Nov 2009 11:47:58 -0500
Received: from mx1.redhat.com ([209.132.183.28]:27227)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <amit.shah@redhat.com>) id 1N504T-0000cl-MI
	for qemu-devel@nongnu.org; Mon, 02 Nov 2009 11:47:57 -0500
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA2GluOX007682
	for <qemu-devel@nongnu.org>; Mon, 2 Nov 2009 11:47:56 -0500
Received: from localhost (vpn-227-7.phx2.redhat.com [10.3.227.7])
	by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id nA2GlpLt006116
	for <qemu-devel@nongnu.org>; Mon, 2 Nov 2009 11:47:55 -0500
Date: Mon, 2 Nov 2009 22:17:11 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20091102164339.GA22757@amit-x200.redhat.com>
References: <1257179398-22110-1-git-send-email-amit.shah@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1257179398-22110-1-git-send-email-amit.shah@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] char: tcp: increase size of buffer that
	holds data to be sent out
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On (Mon) Nov 02 2009 [21:59:58], Amit Shah wrote:
> 1k is too less; at least send out 4k of data from a chardev.

This one only touches unix/tcp sockets; the others use a 1k buffer as
well; I'll send a new patch that converts all the users to a consistent
buffer size.

> 
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
>  qemu-char.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/qemu-char.c b/qemu-char.c
> index 0fd402c..34c0a63 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1996,7 +1996,7 @@ static void tcp_chr_read(void *opaque)
>  {
>      CharDriverState *chr = opaque;
>      TCPCharDriver *s = chr->opaque;
> -    uint8_t buf[1024];
> +    uint8_t buf[4096];
>      int len, size;
>  
>      if (!s->connected || s->max_size <= 0)
> -- 
> 1.6.2.5
> 

		Amit