From: Amit Shah <amit.shah@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] char: tcp: increase size of buffer that holds data to be sent out
Date: Tue, 3 Nov 2009 10:24:58 +0530 [thread overview]
Message-ID: <20091103045458.GA23498@amit-x200.redhat.com> (raw)
In-Reply-To: <4AEF0E32.1080309@codemonkey.ws>
On (Mon) Nov 02 2009 [10:52:02], Anthony Liguori wrote:
> Amit Shah wrote:
>> 1k is too less; at least send out 4k of data from a chardev.
>>
>
> Why is 1k too small?
Definitely depends on the apps that pump in the data. If an app has data
to pump, it will keep pumping as much data as possible (eg, Linux
syscalls issue read / write requests for 32k bytes of data).
The char devices have a 'can_read' call to determine how much the
backend can accept.
We're artificially limiting to 1k in this code, even if the app can pump
and the backend can receive, resulting in multiple splits.
In the case of virtio, 4k is available if the guest is able to receive
data.
Amit
prev parent reply other threads:[~2009-11-03 4:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 16:29 [Qemu-devel] [PATCH] char: tcp: increase size of buffer that holds data to be sent out Amit Shah
2009-11-02 16:47 ` [Qemu-devel] " Amit Shah
2009-11-02 16:52 ` [Qemu-devel] " Anthony Liguori
2009-11-03 4:54 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091103045458.GA23498@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).