From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N5KHQ-0005mA-GU
	for qemu-devel@nongnu.org; Tue, 03 Nov 2009 09:22:40 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N5KHK-0005fL-CL
	for qemu-devel@nongnu.org; Tue, 03 Nov 2009 09:22:39 -0500
Received: from [199.232.76.173] (port=44086 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N5KHK-0005f3-4x
	for qemu-devel@nongnu.org; Tue, 03 Nov 2009 09:22:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60810)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1N5KHJ-0007dQ-Me
	for qemu-devel@nongnu.org; Tue, 03 Nov 2009 09:22:34 -0500
Date: Tue, 3 Nov 2009 16:20:06 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091103142005.GF5605@redhat.com>
References: <1256905286-25435-1-git-send-email-yamahata@valinux.co.jp>
	<1256905286-25435-28-git-send-email-yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1256905286-25435-28-git-send-email-yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH V6 27/32] pci: teach
	pci_default_config_write() ROM bar for normal/bridge device .
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Fri, Oct 30, 2009 at 09:21:21PM +0900, Isaku Yamahata wrote:
> When updated ROM expantion address of header type 0, it missed
> to update mappings.
> Add PCI_ROM_ADDRESS check whether to call pci_update_mappings()
> Also update pci mapping when PCI_ROM_ADDRESS1 is written for header type 1.
> 
> pci_update_mapping() path isn't performance critical,
> so call it even independent of header type.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/pci.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/pci.c b/hw/pci.c
> index d9fd564..46b22ec 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -707,6 +707,8 @@ void pci_default_write_config(PCIDevice *d, uint32_t addr, uint32_t val, int l)
>          d->config[addr] = (d->config[addr] & ~wmask) | (val & wmask);
>      }
>      if (ranges_overlap(addr, l, PCI_BASE_ADDRESS_0, 24) ||
> +        ranges_overlap(addr, l, PCI_ROM_ADDRESS, 4) ||
> +        ranges_overlap(addr, l, PCI_ROM_ADDRESS1, 4) ||
>          range_covers_byte(addr, l, PCI_COMMAND))
>          pci_update_mappings(d);
>  }
> -- 
> 1.6.0.2