From: Amit Shah <amit.shah@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling
Date: Tue, 3 Nov 2009 23:25:52 +0530 [thread overview]
Message-ID: <20091103175552.GA25029@amit-x200.redhat.com> (raw)
In-Reply-To: <4AF063A9.7000908@siemens.com>
On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote:
> Amit Shah wrote:
> > The initial_reset sent to chardevs doesn't do much other than setting
> > a bool to true. Char devices are interested in the open event and
> > that gets sent whenever the device is opened.
>
> Have you checked with the monitor in all use cases (dedicated & muxed
> console, stdio & SDL console, etc.)? It was introduced once to fix a
I've checked with -monitor stdio, monitor in SDL and also chardevs using
unix sockets.
I've not tried mux yet; I'll try that and report back. BTW if it ends up
not working with this patch, it'd be broken in the current master as
well.
> corner case, I think it's even documented...
Hm; I'll have to look really deep; haven't found any such thing yet.
Amit
next prev parent reply other threads:[~2009-11-03 17:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 14:29 [Qemu-devel] char: remove init_reset handling, more data per write() Amit Shah
2009-11-03 14:29 ` [Qemu-devel] [PATCH 1/3] char: don't limit data sent to backends to 1k per buffer Amit Shah
2009-11-03 14:29 ` [Qemu-devel] [PATCH 2/3] char: Remove special init_reset handling Amit Shah
2009-11-03 14:29 ` [Qemu-devel] [PATCH 3/3] char: rename qemu_chr_reset to qemu_chr_generic_open Amit Shah
2009-11-03 17:08 ` [Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling Jan Kiszka
2009-11-03 17:55 ` Amit Shah [this message]
2009-11-03 18:09 ` Amit Shah
2009-11-03 18:53 ` Jan Kiszka
2009-11-04 5:21 ` Amit Shah
2009-11-04 9:39 ` Jan Kiszka
2009-11-04 10:48 ` Amit Shah
2009-11-04 14:30 ` Jan Kiszka
2009-11-04 16:13 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091103175552.GA25029@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).