From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N5Ncb-0001BC-Uf for qemu-devel@nongnu.org; Tue, 03 Nov 2009 12:56:45 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N5NcX-00018b-HV for qemu-devel@nongnu.org; Tue, 03 Nov 2009 12:56:45 -0500 Received: from [199.232.76.173] (port=49048 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5NcX-00018F-Db for qemu-devel@nongnu.org; Tue, 03 Nov 2009 12:56:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29312) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N5NcW-0002CU-UB for qemu-devel@nongnu.org; Tue, 03 Nov 2009 12:56:41 -0500 Date: Tue, 3 Nov 2009 23:25:52 +0530 From: Amit Shah Message-ID: <20091103175552.GA25029@amit-x200.redhat.com> References: <1257258596-4556-1-git-send-email-amit.shah@redhat.com> <1257258596-4556-2-git-send-email-amit.shah@redhat.com> <1257258596-4556-3-git-send-email-amit.shah@redhat.com> <4AF063A9.7000908@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AF063A9.7000908@siemens.com> Subject: [Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: > Amit Shah wrote: > > The initial_reset sent to chardevs doesn't do much other than setting > > a bool to true. Char devices are interested in the open event and > > that gets sent whenever the device is opened. > > Have you checked with the monitor in all use cases (dedicated & muxed > console, stdio & SDL console, etc.)? It was introduced once to fix a I've checked with -monitor stdio, monitor in SDL and also chardevs using unix sockets. I've not tried mux yet; I'll try that and report back. BTW if it ends up not working with this patch, it'd be broken in the current master as well. > corner case, I think it's even documented... Hm; I'll have to look really deep; haven't found any such thing yet. Amit