From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N5dQn-0004Wh-Bw for qemu-devel@nongnu.org; Wed, 04 Nov 2009 05:49:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N5dQi-0004V3-GC for qemu-devel@nongnu.org; Wed, 04 Nov 2009 05:49:36 -0500 Received: from [199.232.76.173] (port=36216 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5dQi-0004V0-87 for qemu-devel@nongnu.org; Wed, 04 Nov 2009 05:49:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9470) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N5dQh-00027G-Ny for qemu-devel@nongnu.org; Wed, 04 Nov 2009 05:49:32 -0500 Date: Wed, 4 Nov 2009 16:18:47 +0530 From: Amit Shah Message-ID: <20091104104847.GA27835@amit-x200.redhat.com> References: <1257258596-4556-1-git-send-email-amit.shah@redhat.com> <1257258596-4556-2-git-send-email-amit.shah@redhat.com> <1257258596-4556-3-git-send-email-amit.shah@redhat.com> <4AF063A9.7000908@siemens.com> <20091103175552.GA25029@amit-x200.redhat.com> <20091103180934.GA25423@amit-x200.redhat.com> <4AF07C37.9040904@web.de> <20091104052113.GA27028@amit-x200.redhat.com> <4AF14BDB.3050306@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AF14BDB.3050306@web.de> Subject: [Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org On (Wed) Nov 04 2009 [10:39:39], Jan Kiszka wrote: > Amit Shah wrote: > > On (Tue) Nov 03 2009 [19:53:43], Jan Kiszka wrote: > >> Amit Shah wrote: > >>> On (Tue) Nov 03 2009 [23:25:52], Amit Shah wrote: > >>>> On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: > >>>>> Amit Shah wrote: > >>>>>> The initial_reset sent to chardevs doesn't do much other than setting > >>>>>> a bool to true. Char devices are interested in the open event and > >>>>>> that gets sent whenever the device is opened. > >>>>> Have you checked with the monitor in all use cases (dedicated & muxed > >>>>> console, stdio & SDL console, etc.)? It was introduced once to fix a > >>>> I've checked with -monitor stdio, monitor in SDL and also chardevs using > >>>> unix sockets. > >>>> > >>>> I've not tried mux yet; I'll try that and report back. BTW if it ends up > >>>> not working with this patch, it'd be broken in the current master as > >>>> well. > >>> I tried with: > >>> > >>> -chardev stdio,mux=on,id=mux -monitor chardev:mux -serial chardev:mux > >>> > >>> The monitor prompt shows up as does the serial output. > >>> > >>> (btw I've also tried closing and opening char devs and that works fine > >>> too) > >> That sounds good. Then something must have changed since 2970a6c943, do > >> you see what? > > > > I think that depended on the resets being sent. I've now removed the > > need for resets altogether. > > No, this is in fact the reason why we no longer need it: > > 9a1e948129 (Introduce contexts for asynchronous callbacks) > > As the initial reset of the char device that is marked pending on open > is now no longer consumed by the IDE initialization, we can actually > drop the later regeneration via qemu_chr_initial_reset. I just hope this > stays like it is... I tested this even on a tree that doesn't have this patch. I haven't really delved deep to see why this was added earlier -- the commit log only says very little. Plus my testing with the current tree works fine so I'm happy to mention these things in the commit log. Amit