From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N7X7Q-00027b-8t
	for qemu-devel@nongnu.org; Mon, 09 Nov 2009 11:29:28 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N7X7I-0001y6-H9
	for qemu-devel@nongnu.org; Mon, 09 Nov 2009 11:29:24 -0500
Received: from [199.232.76.173] (port=51275 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N7X7I-0001xe-0B
	for qemu-devel@nongnu.org; Mon, 09 Nov 2009 11:29:20 -0500
Received: from mx20.gnu.org ([199.232.41.8]:47661)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1N7X7H-0003vO-FK
	for qemu-devel@nongnu.org; Mon, 09 Nov 2009 11:29:19 -0500
Received: from mail.codesourcery.com ([38.113.113.100])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1N7X7G-0007sh-4z
	for qemu-devel@nongnu.org; Mon, 09 Nov 2009 11:29:18 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable.
	Create get_ticks_per_sec() function
Date: Mon, 9 Nov 2009 16:29:15 +0000
References: <cover.1252543871.git.quintela@redhat.com>
	<Pine.LNX.4.64.0909110308350.2097@linmac.oyster.ru>
	<4AAA6E10.6080308@codemonkey.ws>
In-Reply-To: <4AAA6E10.6080308@codemonkey.ws>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <200911091629.15367.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>

On Friday 11 September 2009, Anthony Liguori wrote:
> malc wrote:
> > And generalizations are always true. Anyhow, i'm explicitly against the
> > patch, so first obtain the express acknowledgment from the leaders,
> > otherwise i'll revert it should it go in.
> 
> I'm adding the following patch to Juan's series.  The result is that
> get_ticks_per_sec() should be optimized to a literal value.  The result
> being that uses of it are faster than they were before (not it should
> matter).

Having this as a function/variable is completely misleading. It is and always 
will be 1000000000. You'd be better off using QEMU_TIMER_BASE directly.

Paul