From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N7uB3-0004m5-Hw
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 12:06:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N7uAz-0004kR-Ts
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 12:06:45 -0500
Received: from [199.232.76.173] (port=42899 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N7uAz-0004kL-L6
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 12:06:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17652)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1N7uAz-0003Iu-37
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 12:06:41 -0500
Date: Tue, 10 Nov 2009 15:06:30 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a
	USB thermometer
Message-ID: <20091110150630.19b0c3fa@doriath>
In-Reply-To: <ef2f888d0911100755q1052f2bw7462bee445a7556a@mail.gmail.com>
References: <1257845850-4660-1-git-send-email-scottt.tw@gmail.com>
	<1257845850-4660-2-git-send-email-scottt.tw@gmail.com>
	<1257845850-4660-3-git-send-email-scottt.tw@gmail.com>
	<4AF97D3B.8080601@redhat.com>
	<ef2f888d0911100714k351de5b8hea3a2b48935bde25@mail.gmail.com>
	<374D220D-FE6E-410B-83F3-E8988BA61A6D@suse.de>
	<ef2f888d0911100755q1052f2bw7462bee445a7556a@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Scott Tsai <scottt.tw@gmail.com>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Avi Kivity <avi@redhat.com>

On Tue, 10 Nov 2009 23:55:10 +0800
Scott Tsai <scottt.tw@gmail.com> wrote:

> On Tue, Nov 10, 2009 at 11:33 PM, Alexander Graf <agraf@suse.de> wrote:
> > How about having a monitor command to change the temperature, leveraging a
> > "common interface"?
> > That way in the future real host temperature measurements could maybe get
> > forwarded there too. At least for battery I've had several people ask
> > already if it's possible to read the host battery status (incl. AC status)
> > from inside the VM.
> 
> I'd certainly like to make this code useful for something other than
> developer training.
> How about a new monitor command "thermometer_set" that works like "mouse_move"?
> "thermometer_set" would just set the temperature of the "first"
> thermometer device it finds.

 Couldn't the device be a parameter?

 And I'd suggest usb_therm_set for the name.