From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N7seM-0006qS-4Y
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:28:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N7seH-0006o0-LF
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:28:53 -0500
Received: from [199.232.76.173] (port=38290 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N7seH-0006nr-Du
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:28:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:29771)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1N7seF-0002dw-CE
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:28:48 -0500
Date: Tue, 10 Nov 2009 17:26:13 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091110152613.GC20749@redhat.com>
References: <1256905286-25435-1-git-send-email-yamahata@valinux.co.jp>
	<1256905286-25435-9-git-send-email-yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1256905286-25435-9-git-send-email-yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH V6 08/32] pci: clean up pci_init_wmask()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Fri, Oct 30, 2009 at 09:21:02PM +0900, Isaku Yamahata wrote:
> use pci_set_word() for pci command register.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

I thought I acked this already. It's an obvious one.

> ---
>  hw/pci.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pci.c b/hw/pci.c
> index 6abb0e2..84c7611 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -352,8 +352,8 @@ static void pci_init_wmask(PCIDevice *dev)
>      int i;
>      dev->wmask[PCI_CACHE_LINE_SIZE] = 0xff;
>      dev->wmask[PCI_INTERRUPT_LINE] = 0xff;
> -    dev->wmask[PCI_COMMAND] = PCI_COMMAND_IO | PCI_COMMAND_MEMORY
> -                              | PCI_COMMAND_MASTER;
> +    pci_set_word(dev->wmask + PCI_COMMAND,
> +                 PCI_COMMAND_IO | PCI_COMMAND_MEMORY | PCI_COMMAND_MASTER);
>      for (i = PCI_CONFIG_HEADER_SIZE; i < PCI_CONFIG_SPACE_SIZE; ++i)
>          dev->wmask[i] = 0xff;
>  }
> -- 
> 1.6.0.2
> 
>