From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N7xhd-0005ED-AY
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 15:52:37 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N7xhY-000574-2N
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 15:52:36 -0500
Received: from [199.232.76.173] (port=51236 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N7xhX-00056r-VR
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 15:52:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:27533)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1N7xhX-0005Zk-Ga
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 15:52:31 -0500
Date: Tue, 10 Nov 2009 18:52:18 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a
	USB thermometer
Message-ID: <20091110185218.40468bdf@doriath>
In-Reply-To: <ef2f888d0911100952s557d9364w87913352b37fc4dd@mail.gmail.com>
References: <1257845850-4660-1-git-send-email-scottt.tw@gmail.com>
	<1257845850-4660-2-git-send-email-scottt.tw@gmail.com>
	<1257845850-4660-3-git-send-email-scottt.tw@gmail.com>
	<4AF97D3B.8080601@redhat.com>
	<ef2f888d0911100714k351de5b8hea3a2b48935bde25@mail.gmail.com>
	<374D220D-FE6E-410B-83F3-E8988BA61A6D@suse.de>
	<ef2f888d0911100755q1052f2bw7462bee445a7556a@mail.gmail.com>
	<20091110150630.19b0c3fa@doriath>
	<ef2f888d0911100952s557d9364w87913352b37fc4dd@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Scott Tsai <scottt.tw@gmail.com>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Avi Kivity <avi@redhat.com>

On Wed, 11 Nov 2009 01:52:12 +0800
Scott Tsai <scottt.tw@gmail.com> wrote:

> On Wed, Nov 11, 2009 at 1:06 AM, Luiz Capitulino <lcapitulino@redhat.com>=
 wrote:
> >>
> >> I'd certainly like to make this code useful for something other than
> >> developer training.
> >> How about a new monitor command "thermometer_set" that works like "mou=
se_move"?
> >> "thermometer_set" would just set the temperature of the "first"
> >> thermometer device it finds.
> >
> > =C2=A0Couldn't the device be a parameter?
> >
> > =C2=A0And I'd suggest usb_therm_set for the name.
> >
>=20
> Looking at the existing "mouse_set" and "mouse_move" monitor commands,
> they work on USB, PS/2 and other kinds of mice with "mouse_set" selecting
> the mouse device affected by  "mouse_move".
> So how about a new command "therm_set" which selects the thermometer
> affected by "therm_temp" ?

 This mouse command also selects the current mouse, right?

 I think your case is simpler, you just want to say which thermometer
should get the new temp.

> On a separate note, I understand that if a piece of code is not useful en=
ough
> we don't want to merge it to add to the maintenance burden.

 Alex has given a good reason to merge it, I think.