qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>,
	Juha.Riihimaki@nokia.com, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 00/18] target-arm cleanup
Date: Tue, 10 Nov 2009 23:38:49 +0000	[thread overview]
Message-ID: <200911102338.49991.paul@codesourcery.com> (raw)
In-Reply-To: <761ea48b0910182335v799291a1l755515927e24ee9@mail.gmail.com>

> > Some of the generated tcg code is not very optimal, for example a
> > single vld4.8 instruction can generate over 250 tcg ops. I did some
> > optimizations and got it under 200 but do you think it could be an
> > issue that a single instruction can expand to so many tcg ops? I mean
> > besides the fact that it causes TBs for only one or two guest
> > instructions to be generated.
> 
> Fabrice wrote this (tcg/README):
> 
>   Don't hesitate to use helpers for complicated or seldom used target
>   intructions. There is little performance advantage in using TCG to
>   implement target instructions taking more than about twenty TCG
>   instructions.
> 
> How applicable is it, I can't say.  It'd probably be a good thing
> to benchmark the two versions, TCG vs helper.

The problem is that you can not do memory accesses from within a helper 
function.

Paul

  reply	other threads:[~2009-11-10 23:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-19 15:43 [Qemu-devel] [PATCH 00/18] target-arm cleanup Filip Navara
2009-10-15 17:40 ` Aurelien Jarno
2009-10-15 17:49   ` Laurent Desnogues
2009-10-15 18:36     ` Aurelien Jarno
2009-10-16 15:41   ` Filip Navara
2009-10-16 17:56     ` Aurelien Jarno
2009-10-19  6:23       ` Juha.Riihimaki
2009-10-19  6:35         ` Laurent Desnogues
2009-11-10 23:38           ` Paul Brook [this message]
2009-11-10 23:53             ` Aurelien Jarno
2009-10-19 13:23         ` Aurelien Jarno
2009-10-20  6:18           ` Juha.Riihimaki
2009-11-10 23:39   ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911102338.49991.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=Juha.Riihimaki@nokia.com \
    --cc=aurelien@aurel32.net \
    --cc=laurent.desnogues@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).