From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Scott Tsai <scottt.tw@gmail.com>
Subject: Re: [Qemu-devel] [PATCH V3 0/3] usb-gotemp: USB thermometer emulation
Date: Wed, 11 Nov 2009 04:25:00 +0000 [thread overview]
Message-ID: <200911110425.00243.paul@codesourcery.com> (raw)
In-Reply-To: <1257899043-28415-1-git-send-email-scottt.tw@gmail.com>
On Wednesday 11 November 2009, Scott Tsai wrote:
> I reworked the second patch in this series to add generic monitor commands
> to change the temperature reported from thermometers.
> Thermometer devices can now include "sensor.h" and call
> 'qemu_add_therm_temp_handler' to register themselves.
This is just another HID device. As discussed previously in the context of the
wacom tablet, duplicating this code is bad (IMO usb-wacom.c should ever have
been committed). Instead you should be sharing the existing code.
Paul
prev parent reply other threads:[~2009-11-11 4:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 0:24 [Qemu-devel] [PATCH V3 0/3] usb-gotemp: USB thermometer emulation Scott Tsai
2009-11-11 0:24 ` [Qemu-devel] [PATCH V3 1/3] usb: move HID request defines to hw/usb.h Scott Tsai
2009-11-11 0:24 ` [Qemu-devel] [PATCH V3 2/3] usb-gotemp: new module emulating a USB thermometer Scott Tsai
2009-11-11 0:24 ` [Qemu-devel] [PATCH V3 3/3] Documentation: -usbdevice thermometer option Scott Tsai
2009-11-11 4:25 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911110425.00243.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=scottt.tw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).