From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N84lf-0001Zr-0a for qemu-devel@nongnu.org; Tue, 10 Nov 2009 23:25:15 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N84la-0001X6-Hh for qemu-devel@nongnu.org; Tue, 10 Nov 2009 23:25:14 -0500 Received: from [199.232.76.173] (port=52564 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N84la-0001X2-8q for qemu-devel@nongnu.org; Tue, 10 Nov 2009 23:25:10 -0500 Received: from mx20.gnu.org ([199.232.41.8]:2910) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N84la-0007zn-0u for qemu-devel@nongnu.org; Tue, 10 Nov 2009 23:25:10 -0500 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N84lY-00032b-Tg for qemu-devel@nongnu.org; Tue, 10 Nov 2009 23:25:09 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH V3 0/3] usb-gotemp: USB thermometer emulation Date: Wed, 11 Nov 2009 04:25:00 +0000 References: <1257899043-28415-1-git-send-email-scottt.tw@gmail.com> In-Reply-To: <1257899043-28415-1-git-send-email-scottt.tw@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <200911110425.00243.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Scott Tsai On Wednesday 11 November 2009, Scott Tsai wrote: > I reworked the second patch in this series to add generic monitor commands > to change the temperature reported from thermometers. > Thermometer devices can now include "sensor.h" and call > 'qemu_add_therm_temp_handler' to register themselves. This is just another HID device. As discussed previously in the context of the wacom tablet, duplicating this code is bad (IMO usb-wacom.c should ever have been committed). Instead you should be sharing the existing code. Paul