qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Juan Quintela <quintela@trasno.org>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] configure: use correct cflags in compiler checks
Date: Wed, 11 Nov 2009 14:51:41 +0200	[thread overview]
Message-ID: <20091111125141.GB23036@redhat.com> (raw)
In-Reply-To: <m3fx8lz0ot.fsf@neno.mitica>

On Wed, Nov 11, 2009 at 01:49:06PM +0100, Juan Quintela wrote:
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> Hi
> 
> > @@ -1585,7 +1605,7 @@ int main(void)
> >      return 0;
> >  }
> >  EOF
> > -if $cc $ARCH_CFLAGS -o $TMPE $TMPC 2> /dev/null ; then
> > +if compile_prog "$ARCH_CFLAGS" "" ; then
> 
> s/$ARCH_CFLAGS//
> 
> ARCH_CFLAGS died long ago.

ACK.

> We need to do the same change for dup3

OK.

> This code was this way from the beggining.  I agree that it is better to
> move the QEMU_CFLAGS to the top of the file.
> 
> Later, Juan.

      parent reply	other threads:[~2009-11-11 12:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11 11:50 [Qemu-devel] [PATCH] configure: use correct cflags in compiler checks Michael S. Tsirkin
     [not found] ` <m3fx8lz0ot.fsf@neno.mitica>
2009-11-11 12:51   ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091111125141.GB23036@redhat.com \
    --to=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@trasno.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).