From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N8CiN-00040F-QY
	for qemu-devel@nongnu.org; Wed, 11 Nov 2009 07:54:23 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N8CiI-0003uG-GC
	for qemu-devel@nongnu.org; Wed, 11 Nov 2009 07:54:22 -0500
Received: from [199.232.76.173] (port=49450 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N8CiI-0003u1-3P
	for qemu-devel@nongnu.org; Wed, 11 Nov 2009 07:54:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54708)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1N8CiH-0003cg-KC
	for qemu-devel@nongnu.org; Wed, 11 Nov 2009 07:54:17 -0500
Date: Wed, 11 Nov 2009 14:51:41 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091111125141.GB23036@redhat.com>
References: <20091111115009.GA19210@redhat.com> <m3fx8lz0ot.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3fx8lz0ot.fsf@neno.mitica>
Subject: [Qemu-devel] Re: [PATCH] configure: use correct cflags in compiler
	checks
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@trasno.org>
Cc: qemu-devel@nongnu.org

On Wed, Nov 11, 2009 at 01:49:06PM +0100, Juan Quintela wrote:
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> Hi
> 
> > @@ -1585,7 +1605,7 @@ int main(void)
> >      return 0;
> >  }
> >  EOF
> > -if $cc $ARCH_CFLAGS -o $TMPE $TMPC 2> /dev/null ; then
> > +if compile_prog "$ARCH_CFLAGS" "" ; then
> 
> s/$ARCH_CFLAGS//
> 
> ARCH_CFLAGS died long ago.

ACK.

> We need to do the same change for dup3

OK.

> This code was this way from the beggining.  I agree that it is better to
> move the QEMU_CFLAGS to the top of the file.
> 
> Later, Juan.