From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8Dud-0007yb-Ug for qemu-devel@nongnu.org; Wed, 11 Nov 2009 09:11:07 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8DuY-0007tC-0u for qemu-devel@nongnu.org; Wed, 11 Nov 2009 09:11:05 -0500 Received: from [199.232.76.173] (port=51393 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8DuX-0007sc-Gg for qemu-devel@nongnu.org; Wed, 11 Nov 2009 09:11:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32416) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N8DuW-0000QG-VN for qemu-devel@nongnu.org; Wed, 11 Nov 2009 09:11:01 -0500 Date: Wed, 11 Nov 2009 16:08:19 +0200 From: "Michael S. Tsirkin" Message-ID: <20091111140819.GA29736@redhat.com> References: <20091026131715.GA25271@redhat.com> <200911111301.03427.paul@codesourcery.com> <20091111131253.GC23036@redhat.com> <200911111345.35249.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200911111345.35249.paul@codesourcery.com> Subject: [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On Wed, Nov 11, 2009 at 01:45:35PM +0000, Paul Brook wrote: > If you don't need real barriers, then why does the kvm code have them? We need real barriers but AFAIK kvm does not have them :( IOW: virtio is currently broken with kvm, and my patch did not fix this. The comment that I added says as much. -- MST