From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8EKG-0001Xb-EA for qemu-devel@nongnu.org; Wed, 11 Nov 2009 09:37:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8EKB-0001QL-4O for qemu-devel@nongnu.org; Wed, 11 Nov 2009 09:37:35 -0500 Received: from [199.232.76.173] (port=58194 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8EKA-0001Q3-Ls for qemu-devel@nongnu.org; Wed, 11 Nov 2009 09:37:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41224) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N8EKA-0005Gl-8I for qemu-devel@nongnu.org; Wed, 11 Nov 2009 09:37:30 -0500 Date: Wed, 11 Nov 2009 16:34:49 +0200 From: "Michael S. Tsirkin" Message-ID: <20091111143449.GA30065@redhat.com> References: <20091026131715.GA25271@redhat.com> <200911111345.35249.paul@codesourcery.com> <20091111140819.GA29736@redhat.com> <200911111416.00355.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200911111416.00355.paul@codesourcery.com> Subject: [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On Wed, Nov 11, 2009 at 02:16:00PM +0000, Paul Brook wrote: > On Wednesday 11 November 2009, Michael S. Tsirkin wrote: > > On Wed, Nov 11, 2009 at 01:45:35PM +0000, Paul Brook wrote: > > > If you don't need real barriers, then why does the kvm code have them? > > > > We need real barriers but AFAIK kvm does not have them :( > > IOW: virtio is currently broken with kvm, and my patch did > > not fix this. The comment that I added says as much. > > So your code just makes the bug harder to reproduce? Doesn't sound like a good > thing to me. > > Paul There are multiple bugs, I can't fix all of them, for all architectures, in one patch. -- MST