From: Luiz Capitulino <lcapitulino@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 10/11] Add a QObject JSON wrapper
Date: Wed, 11 Nov 2009 17:58:10 -0200 [thread overview]
Message-ID: <20091111175810.4bcf66ba@doriath> (raw)
In-Reply-To: <4AFB12F1.5080406@codemonkey.ws>
On Wed, 11 Nov 2009 13:39:29 -0600
Anthony Liguori <anthony@codemonkey.ws> wrote:
> Luiz Capitulino wrote:
> > I think we should abort() on error, assuming the only way to fail
> > is a bad syntax.
> >
>
> We'll be using qobject_from_jsonf() to parse incoming QMP traffic. We
> definitely don't want to abort when we receive invalid input on the QMP
> port. Best to just close the session and let the user connect again.
Sure, I just wouldn't like to add a check on every handler call to
qobject_from_jsonf().
What about a new wrapper?
next prev parent reply other threads:[~2009-11-11 19:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 17:28 [Qemu-devel] [PATCH 01/11] Properly escape QDECREF macro arguments Anthony Liguori
2009-11-11 17:28 ` [Qemu-devel] [PATCH 02/11] Add operations to qlist to allow it to be used as a stack Anthony Liguori
2009-11-12 15:33 ` Kevin Wolf
2009-11-12 16:46 ` Anthony Liguori
2009-11-12 16:56 ` Kevin Wolf
2009-11-12 17:13 ` Anthony Liguori
2009-11-12 17:20 ` Luiz Capitulino
2009-11-13 8:51 ` Kevin Wolf
2009-11-12 17:17 ` Ian Molton
2009-11-11 17:28 ` [Qemu-devel] [PATCH 03/11] Allow strings to grow in size Anthony Liguori
2009-11-11 17:28 ` [Qemu-devel] [PATCH 04/11] Add a QFloat datatype Anthony Liguori
2009-11-11 17:28 ` [Qemu-devel] [PATCH 05/11] Add unit test for QFloat Anthony Liguori
2009-11-11 17:28 ` [Qemu-devel] [PATCH 06/11] Add a QBool type Anthony Liguori
2009-11-11 17:28 ` [Qemu-devel] [PATCH 07/11] Add a lexer for JSON Anthony Liguori
2009-11-11 17:29 ` [Qemu-devel] [PATCH 08/11] Add a JSON message boundary identifier Anthony Liguori
2009-11-11 17:29 ` [Qemu-devel] [PATCH 09/11] Add a JSON parser Anthony Liguori
2009-11-11 17:29 ` [Qemu-devel] [PATCH 10/11] Add a QObject JSON wrapper Anthony Liguori
2009-11-11 18:12 ` [Qemu-devel] " Luiz Capitulino
2009-11-11 19:39 ` Anthony Liguori
2009-11-11 19:58 ` Luiz Capitulino [this message]
2009-11-11 17:29 ` [Qemu-devel] [PATCH 11/11] Add a unit test for JSON support Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091111175810.4bcf66ba@doriath \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).