From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N8X0v-00072p-6B
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 05:34:53 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N8X0q-0006vb-AA
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 05:34:52 -0500
Received: from [199.232.76.173] (port=49918 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N8X0p-0006vK-Sb
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 05:34:47 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43080)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1N8X0p-0002wK-FX
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 05:34:47 -0500
Date: Thu, 12 Nov 2009 12:32:14 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091112103214.GE3785@redhat.com>
References: <1258005528-25383-1-git-send-email-yamahata@valinux.co.jp>
	<1258005528-25383-10-git-send-email-yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1258005528-25383-10-git-send-email-yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH 09/20] pci_host: remove unnecessary & 0xff.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Thu, Nov 12, 2009 at 02:58:37PM +0900, Isaku Yamahata wrote:
> This patch removes unnecessary & 0xff in pci_dev_find_by_addr().
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/pci_host.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pci_host.c b/hw/pci_host.c
> index cd2ceb7..672d173 100644
> --- a/hw/pci_host.c
> +++ b/hw/pci_host.c
> @@ -42,8 +42,9 @@ do { printf("pci_host_data: " fmt , ## __VA_ARGS__); } while (0)
>  /* the helper functio to get a PCIDeice* for a given pci address */
>  static inline PCIDevice *pci_dev_find_by_addr(PCIBus *bus, uint32_t addr)
>  {
> -    uint8_t bus_num = (addr >> 16) & 0xff;
> -    uint8_t devfn = (addr >> 8) & 0xff;
> +    uint8_t bus_num = addr >> 16;
> +    uint8_t devfn = addr >> 8;
> +
>      return pci_find_device(bus, bus_num, PCI_SLOT(devfn), PCI_FUNC(devfn));
>  }
>  
> -- 
> 1.6.0.2