From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N8X1k-0007ym-8U
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 05:35:44 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N8X1f-0007wW-Jw
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 05:35:43 -0500
Received: from [199.232.76.173] (port=56014 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N8X1f-0007wR-7k
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 05:35:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48877)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1N8X1e-000335-Fi
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 05:35:38 -0500
Date: Thu, 12 Nov 2009 12:33:06 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091112103306.GG3785@redhat.com>
References: <1258005528-25383-1-git-send-email-yamahata@valinux.co.jp>
	<1258005528-25383-13-git-send-email-yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1258005528-25383-13-git-send-email-yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH 12/20] pci: remove some unnecessary comment
	in pci.h
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Thu, Nov 12, 2009 at 02:58:40PM +0900, Isaku Yamahata wrote:
> This patch removes some comment which should go into commit log
> in pci.h.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/pci.h |   11 ++---------
>  1 files changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/hw/pci.h b/hw/pci.h
> index cd04189..988d2c0 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -382,17 +382,10 @@ typedef struct {
>      PCIConfigWriteFunc *config_write;
>  
>      /* pci config header type */
> -    uint8_t header_type;        /* this is necessary for initialization
> -                                 * code to know its header type before
> -                                 * device specific code can initialize
> -                                 * configuration space.
> -                                 */
> +    uint8_t header_type;
>  
>      /* pcie stuff */
> -    int is_express;   /* is this device pci express?
> -                       * initialization code needs to know this before
> -                       * each specific device initialization.
> -                       */
> +    int is_express;   /* is this device pci express? */
>  } PCIDeviceInfo;
>  
>  void pci_qdev_register(PCIDeviceInfo *info);
> -- 
> 1.6.0.2