From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N8X2s-0000IU-0U
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 05:36:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N8X2n-0000F6-9Q
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 05:36:53 -0500
Received: from [199.232.76.173] (port=56088 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N8X2m-0000Ev-Vg
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 05:36:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23409)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1N8X2m-0003JC-HH
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 05:36:48 -0500
Date: Thu, 12 Nov 2009 12:34:16 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091112103416.GJ3785@redhat.com>
References: <1258005528-25383-1-git-send-email-yamahata@valinux.co.jp>
	<1258005528-25383-16-git-send-email-yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1258005528-25383-16-git-send-email-yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH 15/20] pci: clean up of
	pci_update_mappings()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Thu, Nov 12, 2009 at 02:58:43PM +0900, Isaku Yamahata wrote:
> This patch converts r->size == 0 to !r_size.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/pci.c b/hw/pci.c
> index 9698efb..cae3d53 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -732,7 +732,7 @@ static void pci_update_mappings(PCIDevice *d)
>          r = &d->io_regions[i];
>  
>          /* this region isn't registered */
> -        if (r->size == 0)
> +        if (!r->size)
>              continue;
>  
>          if (r->type & PCI_BASE_ADDRESS_SPACE_IO) {
> -- 
> 1.6.0.2