From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N8vJB-0007fU-Nb
	for qemu-devel@nongnu.org; Fri, 13 Nov 2009 07:31:21 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N8vJ6-0007TR-DW
	for qemu-devel@nongnu.org; Fri, 13 Nov 2009 07:31:20 -0500
Received: from [199.232.76.173] (port=48564 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N8vJ6-0007T1-6w
	for qemu-devel@nongnu.org; Fri, 13 Nov 2009 07:31:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:13163)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1N8vJ5-0006JZ-LC
	for qemu-devel@nongnu.org; Fri, 13 Nov 2009 07:31:15 -0500
Date: Fri, 13 Nov 2009 10:31:03 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/9] QJSON: Introduce qobject_from_json_va()
Message-ID: <20091113103103.0322a9d7@doriath>
In-Reply-To: <4AFC8082.8060402@codemonkey.ws>
References: <1258058554-22872-1-git-send-email-lcapitulino@redhat.com>
	<1258058554-22872-2-git-send-email-lcapitulino@redhat.com>
	<4AFC8082.8060402@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: armbru@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, kraxel@redhat.com

On Thu, 12 Nov 2009 15:39:14 -0600
Anthony Liguori <anthony@codemonkey.ws> wrote:

> Luiz Capitulino wrote:
> > Accepts a va_list, will be used by QError.
> >
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  qjson.c |   14 ++++++++++++++
> >  qjson.h |    2 ++
> >  2 files changed, 16 insertions(+), 0 deletions(-)
> >
> > diff --git a/qjson.c b/qjson.c
> > index 7270909..491b61e 100644
> > --- a/qjson.c
> > +++ b/qjson.c
> > @@ -64,6 +64,20 @@ QObject *qobject_from_jsonf(const char *string, ...)
> >      return state.result;
> >  }
> >  
> > +QObject *qobject_from_json_va(const char *string, va_list *ap)
> > +{
> > +    JSONParsingState state = {};
> > +
> > +    state.ap = ap;
> > +
> > +    json_message_parser_init(&state.parser, parse_json);
> > +    json_message_parser_feed(&state.parser, string, strlen(string));
> > +    json_message_parser_flush(&state.parser);
> > +    json_message_parser_destroy(&state.parser);
> > +
> > +    return state.result;
> > +}
> > +
> >   
> 
> qobject_from_jsonf() should just call qobject_from_json_va().

 Right.

> >  typedef struct ToJsonIterState
> >  {
> >      int count;
> > diff --git a/qjson.h b/qjson.h
> > index 7fce742..8b89e41 100644
> > --- a/qjson.h
> > +++ b/qjson.h
> > @@ -14,12 +14,14 @@
> >  #ifndef QJSON_H
> >  #define QJSON_H
> >  
> > +#include <stdarg.h>
> >   
> 
> qemu-common.h is a better way to get stdarg.h

 Why? I usually don't include qemu-common.h when all I need
are one or two headers.