From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NAM2Z-0003j4-RB
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:16:08 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NAM2U-0003el-A5
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:16:07 -0500
Received: from [199.232.76.173] (port=37938 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NAM2T-0003eh-TR
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:16:01 -0500
Received: from verein.lst.de ([213.95.11.210]:55724)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1NAM2T-0007t6-DS
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:16:01 -0500
Date: Tue, 17 Nov 2009 12:16:00 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 04/15] scsi: add scsi_req_init()
Message-ID: <20091117111559.GD31958@lst.de>
References: <1258453071-3496-1-git-send-email-kraxel@redhat.com>
	<1258453071-3496-5-git-send-email-kraxel@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1258453071-3496-5-git-send-email-kraxel@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, Nov 17, 2009 at 11:17:40AM +0100, Gerd Hoffmann wrote:
> Helper function to init SCSIRequest, so scsi-disk and scsi-generic
> don't duplicate init code for the common bits.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>