From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NAMdo-0005Fa-W5 for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:54:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NAMdk-0005DJ-8b for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:54:36 -0500 Received: from [199.232.76.173] (port=56094 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAMdj-0005DC-Tn for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:54:32 -0500 Received: from verein.lst.de ([213.95.11.210]:45545) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1NAMdj-0005Ub-Aw for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:54:31 -0500 Date: Tue, 17 Nov 2009 12:54:29 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 12/15] scsi: move sense to SCSIDevice, create SCSISense struct. Message-ID: <20091117115429.GD1330@lst.de> References: <1258453071-3496-1-git-send-email-kraxel@redhat.com> <1258453071-3496-13-git-send-email-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1258453071-3496-13-git-send-email-kraxel@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Looks good. Long term we might want to make this a pointer to be able to deal with block format sense descriptors more nicely.