From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NAMf1-0005u6-8r for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:55:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NAMew-0005rp-MT for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:55:51 -0500 Received: from [199.232.76.173] (port=56115 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAMew-0005rV-FE for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:55:46 -0500 Received: from mx20.gnu.org ([199.232.41.8]:59141) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NAMew-0005eQ-5N for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:55:46 -0500 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NAMeu-0003t1-O2 for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:55:45 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericReq to SCSIRequest. Date: Tue, 17 Nov 2009 11:55:37 +0000 References: <1258453071-3496-1-git-send-email-kraxel@redhat.com> <1258453071-3496-6-git-send-email-kraxel@redhat.com> In-Reply-To: <1258453071-3496-6-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <200911171155.37272.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann > move scsi command from SCSIGenericReq to SCSIRequest. Why? AFAICS This has precisely one user, and more importantly it is not populated by scsi-disk.c. Sharing common code is good. Implementing shared fields inconsistently or putting implementation specific fields in common structures. Paul