From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NAMj9-0001Fi-W8 for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:00:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NAMj4-00019I-Vn for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:00:07 -0500 Received: from [199.232.76.173] (port=36039 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAMj4-00018l-P1 for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:00:02 -0500 Received: from mx20.gnu.org ([199.232.41.8]:59467) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NAMj2-0006JV-Ko for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:00:02 -0500 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NAMj1-000492-9H for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:59:59 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 03/15] scsi: move request lists to QTAILQ. Date: Tue, 17 Nov 2009 11:59:54 +0000 References: <1258453071-3496-1-git-send-email-kraxel@redhat.com> <1258453071-3496-4-git-send-email-kraxel@redhat.com> In-Reply-To: <1258453071-3496-4-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <200911171159.54656.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann On Tuesday 17 November 2009, Gerd Hoffmann wrote: > Changes: > * Move from open-coded lists to QTAILQ macros. > * Move the struct elements to the common data structures > (SCSIDevice + SCSIRequest). > * Fix request cleanup in the destroy callback. This feels like the abstraction boundaries wrong. If the request chain fields are in common structures then I'd also expect the allocation and linking code to be common. Paul