From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NANAF-0005uw-C1
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:28:07 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NANAA-0005o3-7D
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:28:06 -0500
Received: from [199.232.76.173] (port=50606 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NANA9-0005nn-DG
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:28:01 -0500
Received: from mx20.gnu.org ([199.232.41.8]:61764)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1NANA9-00025f-4U
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:28:01 -0500
Received: from mail.codesourcery.com ([38.113.113.100])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1NANA8-0005y7-7V
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:28:00 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into
	generic code.
Date: Tue, 17 Nov 2009 12:27:56 +0000
References: <1258453071-3496-1-git-send-email-kraxel@redhat.com>
	<1258453071-3496-10-git-send-email-kraxel@redhat.com>
	<20091117115047.GA1330@lst.de>
In-Reply-To: <20091117115047.GA1330@lst.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200911171227.56645.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Christoph Hellwig <hch@lst.de>, Gerd Hoffmann <kraxel@redhat.com>

On Tuesday 17 November 2009, Christoph Hellwig wrote:
> The subject is a bit confusing - it's not the full request parsing but
> just some helpers.

This is a good example of a patch with an insufficient commit message.
Given the way GIT treats the first line of the commit mesaage, my advice is to 
make both the subject and the body of the commit message independent.

On a more technical note, why aren't you also using this function in scsi-
disc.c? Surely that's the whole point of moving it into common code.

Paul