From: Jamie Lokier <jamie@shareable.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org,
virtualization <virtualization@lists.linux-foundation.org>,
Avi Kivity <avi@redhat.com>, Adam Litke <agl@us.ibm.com>
Subject: Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V2)
Date: Wed, 18 Nov 2009 16:56:30 +0000 [thread overview]
Message-ID: <20091118165630.GB28723@shareable.org> (raw)
In-Reply-To: <4B040C82.6070901@codemonkey.ws>
Anthony Liguori wrote:
> Rusty Russell wrote:
> >The little-endian conversion of the balloon driver is a historical mistake
> >(no other driver does this). Let's not extend it to the stats.
>
> I think the mistake is that the other drivers don't do that.
>
> We cheat in qemu and assume that the guest is always in a fixed
> endianness but this is not always the case for all architectures.
If guests can have different endianness (reasonable on some CPUs where
it's switchable - some even have more than 2 options), then I guess
the *host* on those systems have different endianness too.
Is the host's endianness signalled to the guest anywhere, so that
guest drivers can do cpu_to_qemuhost32(), when someone eventually
finds that necessary?
-- Jamie
next prev parent reply other threads:[~2009-11-18 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 20:16 [Qemu-devel] virtio: Report new guest memory statistics pertinent to memory ballooning (V3) Adam Litke
2009-11-17 20:36 ` [Qemu-devel] virtio: Add memory statistics reporting to the balloon driver (V2) Adam Litke
2009-11-18 1:30 ` [Qemu-devel] " Rusty Russell
2009-11-18 15:02 ` Anthony Liguori
2009-11-18 16:56 ` Jamie Lokier [this message]
2009-11-19 0:36 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091118165630.GB28723@shareable.org \
--to=jamie@shareable.org \
--cc=agl@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).