From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] posix-aio-compat: Fix error check
Date: Wed, 18 Nov 2009 20:04:33 +0100 [thread overview]
Message-ID: <20091118190433.GB29881@lst.de> (raw)
In-Reply-To: <1258542910-724-1-git-send-email-kwolf@redhat.com>
On Wed, Nov 18, 2009 at 12:15:10PM +0100, Kevin Wolf wrote:
> Checking for nbytes < 0 is pointless as long as it's a size_t. If we want to
> use negative numbers for error codes, we should use signed types.
Indeed, patch looks good.
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2009-11-18 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 11:15 [Qemu-devel] [PATCH] posix-aio-compat: Fix error check Kevin Wolf
2009-11-18 19:04 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091118190433.GB29881@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).