From: Rusty Russell <rusty@rustcorp.com.au>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>,
virtualization <virtualization@lists.linux-foundation.org>,
linux-kernel@vger.kernel.org, Adam Litke <agl@us.ibm.com>
Subject: Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V2)
Date: Thu, 19 Nov 2009 11:06:38 +1030 [thread overview]
Message-ID: <200911191106.38976.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4B040C82.6070901@codemonkey.ws>
On Thu, 19 Nov 2009 01:32:26 am Anthony Liguori wrote:
> Rusty Russell wrote:
> > The little-endian conversion of the balloon driver is a historical mistake
> > (no other driver does this). Let's not extend it to the stats.
>
> I think the mistake is that the other drivers don't do that.
>
> We cheat in qemu and assume that the guest is always in a fixed
> endianness but this is not always the case for all architectures.
Perhaps, but it's documented in the spec. My assertion remains that to do
any virtualization you need to know what the guest endian is anyway, so
endian converts throughout the drivers just add pain for driver authors.
> I think making the interface u64 and byte based would be the best
> solution. Making assumptions about page size across guest and host is
> another thing we should try to avoid.
Yep, just report the raw byte counts as u64.
Cheers,
Rusty.
prev parent reply other threads:[~2009-11-19 0:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 20:16 [Qemu-devel] virtio: Report new guest memory statistics pertinent to memory ballooning (V3) Adam Litke
2009-11-17 20:36 ` [Qemu-devel] virtio: Add memory statistics reporting to the balloon driver (V2) Adam Litke
2009-11-18 1:30 ` [Qemu-devel] " Rusty Russell
2009-11-18 15:02 ` Anthony Liguori
2009-11-18 16:56 ` Jamie Lokier
2009-11-19 0:36 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911191106.38976.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=agl@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).