From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NBNrH-0003ku-2n
	for qemu-devel@nongnu.org; Fri, 20 Nov 2009 02:24:43 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NBNrC-0003g0-6i
	for qemu-devel@nongnu.org; Fri, 20 Nov 2009 02:24:42 -0500
Received: from [199.232.76.173] (port=40269 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NBNrB-0003fn-W0
	for qemu-devel@nongnu.org; Fri, 20 Nov 2009 02:24:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49218)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <amit.shah@redhat.com>) id 1NBNrB-0008TQ-Hy
	for qemu-devel@nongnu.org; Fri, 20 Nov 2009 02:24:37 -0500
Date: Fri, 20 Nov 2009 12:53:46 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 09/10] qdev: Use QError for 'device not
	found' error
Message-ID: <20091120072346.GA4112@amit-x200.redhat.com>
References: <1258487037-24950-1-git-send-email-lcapitulino@redhat.com>
	<1258487037-24950-10-git-send-email-lcapitulino@redhat.com>
	<m31vjvg8wh.fsf@crossbow.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m31vjvg8wh.fsf@crossbow.pond.sub.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: aliguori@us.ibm.com, kraxel@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On (Wed) Nov 18 2009 [16:17:02], Markus Armbruster wrote:
> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > @@ -176,8 +177,7 @@ DeviceState *qdev_device_add(QemuOpts *opts)
> >      /* find driver */
> >      info = qdev_find_info(NULL, driver);
> >      if (!info) {
> > -        qemu_error("Device \"%s\" not found.  Try -device '?' for a list.\n",
> > -                   driver);
> > +        qemu_error_new(QERR_DEVICE_NOT_FOUND, driver);
> >          return NULL;
> >      }
> >      if (info->no_user) {
> 
> Not obvious from this patch, but we lose the "Try -device '?' for a
> list" hint here.  In PATCH 7/10:

BTW that hint isn't always appropriate as it's printed on the monitor
when doing 'device_add' as well.

		Amit