From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting
Date: Fri, 20 Nov 2009 17:41:13 +0000 [thread overview]
Message-ID: <200911201741.14183.paul@codesourcery.com> (raw)
In-Reply-To: <1258450699-24445-2-git-send-email-kraxel@redhat.com>
On Tuesday 17 November 2009, Gerd Hoffmann wrote:
> Add a greeting string to CharDriverState which is printed after
> initialization. Used to have the qemu vc consoles labeled. This
> way we can avoid walking all the chardevs a second time after
> initialization just to print the greeting.
I think "greeting" is propagating a bad idea into new code. Much better would
be some form of ID and/or human readable description that can also be used
elsewhere.
Paul
next prev parent reply other threads:[~2009-11-20 17:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 9:38 [Qemu-devel] [PATCH 0/9] fixup default device handling Gerd Hoffmann
2009-11-17 9:38 ` [Qemu-devel] [PATCH 1/9] chardev: add greeting Gerd Hoffmann
2009-11-20 17:00 ` Markus Armbruster
2009-11-20 17:41 ` Paul Brook [this message]
2009-11-23 8:22 ` Gerd Hoffmann
2009-11-23 13:26 ` Paul Brook
2009-11-23 15:10 ` Gerd Hoffmann
2009-11-23 15:18 ` Paul Brook
2009-11-23 15:20 ` Daniel P. Berrange
2009-11-23 15:20 ` Anthony Liguori
2009-11-23 16:13 ` Gerd Hoffmann
2009-12-02 14:55 ` Anthony Liguori
2009-11-17 9:38 ` [Qemu-devel] [PATCH 2/9] default devices: core code & serial lines Gerd Hoffmann
2009-11-20 16:48 ` Markus Armbruster
2009-11-17 9:38 ` [Qemu-devel] [PATCH 3/9] default devices: parallel port Gerd Hoffmann
2009-11-20 16:52 ` Markus Armbruster
2009-11-17 9:38 ` [Qemu-devel] [PATCH 4/9] default devices: monitor Gerd Hoffmann
2009-11-20 16:59 ` Markus Armbruster
2009-11-17 9:38 ` [Qemu-devel] [PATCH 5/9] zap serial_monitor_mux Gerd Hoffmann
2009-11-17 9:38 ` [Qemu-devel] [PATCH 6/9] default devices: vga Gerd Hoffmann
2009-11-17 9:38 ` [Qemu-devel] [PATCH 7/9] default devices: net Gerd Hoffmann
2009-11-17 9:38 ` [Qemu-devel] [PATCH 8/9] default devices: drives Gerd Hoffmann
2009-11-17 9:38 ` [Qemu-devel] [PATCH 9/9] default devices: global switch Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911201741.14183.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).