From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBXUE-00061R-AY for qemu-devel@nongnu.org; Fri, 20 Nov 2009 12:41:34 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBXU9-0005se-Gk for qemu-devel@nongnu.org; Fri, 20 Nov 2009 12:41:33 -0500 Received: from [199.232.76.173] (port=35747 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBXU9-0005sI-7r for qemu-devel@nongnu.org; Fri, 20 Nov 2009 12:41:29 -0500 Received: from mx20.gnu.org ([199.232.41.8]:17722) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NBXU8-00077f-JR for qemu-devel@nongnu.org; Fri, 20 Nov 2009 12:41:29 -0500 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NBXTz-0000to-R3 for qemu-devel@nongnu.org; Fri, 20 Nov 2009 12:41:20 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting Date: Fri, 20 Nov 2009 17:41:13 +0000 References: <1258450699-24445-1-git-send-email-kraxel@redhat.com> <1258450699-24445-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1258450699-24445-2-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <200911201741.14183.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann On Tuesday 17 November 2009, Gerd Hoffmann wrote: > Add a greeting string to CharDriverState which is printed after > initialization. Used to have the qemu vc consoles labeled. This > way we can avoid walking all the chardevs a second time after > initialization just to print the greeting. I think "greeting" is propagating a bad idea into new code. Much better would be some form of ID and/or human readable description that can also be used elsewhere. Paul