From: Kevin O'Connor <kevin@koconnor.net>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, KVM list <kvm@vger.kernel.org>
Subject: [Qemu-devel] Re: SeaBIOS cdrom regression with Vista
Date: Fri, 20 Nov 2009 14:08:03 -0500 [thread overview]
Message-ID: <20091120190803.GA22484@morn.localdomain> (raw)
In-Reply-To: <20091120180351.GA21458@morn.localdomain>
On Fri, Nov 20, 2009 at 01:03:51PM -0500, Kevin O'Connor wrote:
> I've looked into this, and it looks like the cdrom is left in an odd
> state. At this point, I think SeaBIOS is tickling a bug outside of
> seabios (eg, in Vista or qemu). I would appreciate it someone with
> cdrom knowledge of qemu could help.
[...]
> SeaBIOS has a different ata drive detection mechanism than bochs - it
> needs it in order to work on real hardware. So, this explains why
> bochs bios doesn't show this issue. (Seabios tries to send an
> "identify packet device" and then an "identify device" command to
> detect a drive; bochs bios looks for a signature in the ata registers
> after an ata reset.)
It looks like I spoke too soon. It appears the SeaBIOS init can leave
the ATA controller in an interrupts disabled state. This appears to
confuse Vista. So, this is a SeaBIOS bug - I'll implement a fix.
The patch below enables Vista to see the cdrom (though, it's not a
real fix).
-Kevin
--- a/src/ata.c
+++ b/src/ata.c
@@ -237,6 +237,7 @@ send_cmd(struct drive_s *drive_g, struct ata_pio_command *cmd)
return -4;
}
if (!(status & ATA_CB_STAT_DRQ)) {
+ outb(ATA_CB_DC_HD15, iobase2+ATA_CB_DC);
dprintf(6, "send_cmd : DRQ not set (status %02x)\n", status);
return -5;
}
next prev parent reply other threads:[~2009-11-20 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 13:21 [Qemu-devel] SeaBIOS cdrom regression with Vista Avi Kivity
2009-11-17 17:07 ` Stefan Weil
2009-11-18 5:19 ` [Qemu-devel] " Kevin O'Connor
2009-11-19 3:24 ` Kevin O'Connor
2009-11-19 10:25 ` Avi Kivity
2009-11-20 18:03 ` Kevin O'Connor
2009-11-20 19:08 ` Kevin O'Connor [this message]
2009-11-20 22:36 ` Kevin O'Connor
2009-11-22 8:56 ` Avi Kivity
2009-11-26 15:31 ` Avi Kivity
2009-11-19 15:34 ` Avi Kivity
2009-11-19 15:40 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091120190803.GA22484@morn.localdomain \
--to=kevin@koconnor.net \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).